Skip to content
Commit 1c985952 authored by Gregory Nutt's avatar Gregory Nutt
Browse files

syslog: There is yet another place where the output can get split. That is...

syslog:  There is yet another place where the output can get split.  That is in syslog_dev_write():  It will break up the stream to insert a CR before the LF.  This can that can be avoid be generating the CR-LF sequence in the buffer and then detecting and ignoring valid CR-LF sequences, rather than expecting syslog_dev_write() to insert the CR in this case.

I don't like the idea that syslog_dev_write() still scans the entire output buffer to expand CR-LF sequence.  This seems really wasteful, especially in this case where we can be sure that the is no CR or LF without a matching LF or CR.  Bu, I think, the existing behavior in syslog_dev_write() must be retained because it is needed in other contexts.
parent 0fc068cc
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment