Most cosmetic, but includes some fixes to some range checking

libc/pthread/pthread_attrsetschedparam.c

@@ -45,6 +45,10 @@
 #include <debug.h>
 #include <errno.h>
 
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
 /****************************************************************************
  * Function:  pthread_attr_setschedparam
  *

libc/sched/sched_getprioritymax.c

 /************************************************************************
  * libc/sched/sched_getprioritymax.c
  *
- *   Copyright (C) 2007, 2009, 2011 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2007, 2009, 2011, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -39,31 +39,9 @@
 
 #include <nuttx/config.h>
 
-#include <nuttx/arch.h>
-
-/************************************************************************
- * Pre-processor Definitions
- ************************************************************************/
-
-/************************************************************************
- * Private Type Declarations
- ************************************************************************/
-
-/************************************************************************
- * Global Variables
- ************************************************************************/
+#include <assert.h>
 
-/************************************************************************
- * Private Variables
- ************************************************************************/
-
-/************************************************************************
- * Private Function Prototypes
- ************************************************************************/
-
-/************************************************************************
- * Private Functions
- ************************************************************************/
+#include <nuttx/arch.h>
 
 /************************************************************************
  * Public Functions
@@ -89,12 +67,6 @@
 
 int sched_get_priority_max(int policy)
 {
-  if (policy != SCHED_FIFO && policy != SCHED_RR)
-    {
-      return ERROR;
-    }
-  else
-    {
-      return SCHED_PRIORITY_MAX;
-    }
+  DEBUGASSERT(policy >= SCHED_FIFO && policy <= SCHED_OTHER);
+  return SCHED_PRIORITY_MAX;
 }

libc/sched/sched_getprioritymin.c

 /************************************************************************
  * libc/sched/sched_getprioritymin.c
  *
- *   Copyright (C) 2007, 2009, 2011 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2007, 2009, 2011, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -39,31 +39,9 @@
 
 #include <nuttx/config.h>
 
-#include <nuttx/arch.h>
-
-/************************************************************************
- * Pre-processor Definitions
- ************************************************************************/
-
-/************************************************************************
- * Private Type Declarations
- ************************************************************************/
-
-/************************************************************************
- * Global Variables
- ************************************************************************/
+#include <assert.h>
 
-/************************************************************************
- * Private Variables
- ************************************************************************/
-
-/************************************************************************
- * Private Function Prototypes
- ************************************************************************/
-
-/************************************************************************
- * Private Functions
- ************************************************************************/
+#include <nuttx/arch.h>
 
 /************************************************************************
  * Public Functions
@@ -89,12 +67,6 @@
 
 int sched_get_priority_min(int policy)
 {
-  if (policy != SCHED_FIFO && policy != SCHED_RR)
-    {
-      return ERROR;
-    }
-  else
-    {
-      return SCHED_PRIORITY_MIN;
-    }
+  DEBUGASSERT(policy >= SCHED_FIFO && policy <= SCHED_OTHER);
+  return SCHED_PRIORITY_MIN;
 }

libc/spawn/lib_psa_setschedparam.c

@@ -44,7 +44,7 @@
 #include <assert.h>
 
 /****************************************************************************
- * Global Functions
+ * Public Functions
  ****************************************************************************/
 
 /****************************************************************************

sched/pthread/pthread_create.c

@@ -58,16 +58,9 @@
 #include "pthread/pthread.h"
 
 /****************************************************************************
- * Pre-processor Definitions
+ * Public Data
  ****************************************************************************/
 
-/****************************************************************************
- * Private Type Declarations
- ****************************************************************************/
-
-/****************************************************************************
- * Global Variables
- ****************************************************************************/
 /* Default pthread attributes (see include/nuttx/pthread.h).  When configured
  * to build separate kernel- and user-address spaces, this global is
  * duplicated in each address spaced.  This copy can only be shared within
@@ -77,7 +70,7 @@
 const pthread_attr_t g_default_pthread_attr = PTHREAD_ATTR_INITIALIZER;
 
 /****************************************************************************
- * Private Variables
+ * Private Data
  ****************************************************************************/
 
 /* This is the name for name-less pthreads */

sched/sched/sched_setparam.c

@@ -48,30 +48,6 @@
 #include "clock/clock.h"
 #include "sched/sched.h"
 
-/****************************************************************************
- * Pre-processor Definitions
- ****************************************************************************/
-
-/****************************************************************************
- * Private Type Declarations
- ****************************************************************************/
-
-/****************************************************************************
- * Global Variables
- ****************************************************************************/
-
-/****************************************************************************
- * Private Variables
- ****************************************************************************/
-
-/****************************************************************************
- * Private Function Prototypes
- ****************************************************************************/
-
-/****************************************************************************
- * Private Functions
- ****************************************************************************/
-
 /****************************************************************************
  * Public Functions
  ****************************************************************************/

sched/sched/sched_setscheduler.c

@@ -49,30 +49,6 @@
 #include "sched/sched.h"
 #include "clock/clock.h"
 
-/****************************************************************************
- * Pre-processor Definitions
- ****************************************************************************/
-
-/****************************************************************************
- * Private Type Declarations
- ****************************************************************************/
-
-/****************************************************************************
- * Global Variables
- ****************************************************************************/
-
-/****************************************************************************
- * Private Variables
- ****************************************************************************/
-
-/****************************************************************************
- * Private Function Prototypes
- ****************************************************************************/
-
-/****************************************************************************
- * Private Functions
- ****************************************************************************/
-
 /****************************************************************************
  * Public Functions
  ****************************************************************************/

sched/task/task_spawnparms.c

@@ -49,10 +49,6 @@
 #include "task/spawn.h"
 #include "task/task.h"
 
-/****************************************************************************
- * Private Types
- ****************************************************************************/
-
 /****************************************************************************
  * Public Data
  ****************************************************************************/
@@ -63,10 +59,6 @@ sem_t g_spawn_execsem = SEM_INITIALIZER(0);
 #endif
 struct spawn_parms_s g_spawn_parms;
 
-/****************************************************************************
- * Private Data
- ****************************************************************************/
-
 /****************************************************************************
  * Private Functions
  ****************************************************************************/
@@ -310,7 +302,7 @@ int spawn_execattrs(pid_t pid, FAR const posix_spawnattr_t *attr)
  *   file_actions - The attributes to use
  *
  * Returned Value:
- *   0 (OK) on successed; A negated errno value is returned on failure.
+ *   0 (OK) on success; A negated errno value is returned on failure.
  *
  ****************************************************************************/