Skip to content
  1. Dec 07, 2017
    • Jussi Kivilinna's avatar
      From c73dd8973accd312ca7675fde044df80e9cc62d5 Mon Sep 17 00:00:00 2001 · ce88bc21
      Jussi Kivilinna authored 
      From: Jussi Kivilinna <jussi.kivilinna@haltian.com>
Date: Thu, 7 Dec 2017 13:00:14 +0200
Subject: [PATCH] drivers/pipes: poll: fix off-by-one error in calculation of bytes in the buffer

Buffer calculation in pipe poll setup is off-by-one when read indexis larger than write index. This causes poll() not getting POLLINwhen buffer has one byte as calculation gives zero bytes in buffer.

Reproducible with:

  {
    char buf[8] = { 0, };
    int fds[2];
    struct pollfd in_pfd;

    pipe2(fds, 8);

    write(fds[1], buf, 7);
    read(fds[0], buf, 7);
    write(fds[1], buf, 1);

    in_pfd.fd = fds[0];
    in_pfd.events = POLLIN;
    ret = poll(&in_pfd, 1, -1); // pipe bug => stuck waiting
    assert(ret == 1);
  }
      ce88bc21
  3. Dec 04, 2017
  5. Dec 03, 2017
  7. Dec 02, 2017
  9. Nov 30, 2017
  11. Nov 29, 2017
  13. Nov 28, 2017
  15. Nov 27, 2017
  17. Nov 26, 2017
  19. Nov 25, 2017